quantiom / AdvancedVanish

A fully customizable and advanced Spigot plugin for vanishing.
https://quantioms.gitbook.io/advancedvanish/
MIT License
8 stars 10 forks source link

Vanished players are able to be messaged with ChatControlRed #15

Closed RhinoCD closed 2 years ago

RhinoCD commented 2 years ago

image

Maybe a way to prevent players from messaging someone in vanish? / running commands on players who are in vanish

RhinoCD commented 2 years ago

Same with things like /trade, etc.

quantiom commented 2 years ago

It's only possible to do this if those specific plugins add checks for vanished players (or it can be added as a hook to AdvancedVanish). Which plugins do you use for messaging and trading?

RhinoCD commented 2 years ago

ChatControlRed - I don’t know if trading actually works or has checks ill have to verify, but messaging I guess is the important one. Trading would be TradeSystems

quantiom commented 2 years ago

I don't think it will be possible for me to add a hook for that plugin. On the API page of the plugin's wiki, it says to PM "kangarko" on Spigot for a free developer license, but it looks like he's been banned.

Also, to use the API, it says:

using the systemPath dependency scope in Maven or importing as a library in your build path,

which would not be possible for me to add to AdvancedVanish without distributing the paid plugin for free.

I would recommend opening an issue there and probably referencing this issue in it.

RhinoCD commented 2 years ago

Okay! tysm

On Aug 10, 2022, at 9:51 PM, quantiom @.***> wrote:

 I don't think it will be possible for me to add a hook for that plugin. On the API page of the plugin's wiki, it says to PM "kangarko" on Spigot for a free developer license, but it looks like he's been banned.

Also, to use the API, it says:

using the systemPath dependency scope in Maven or importing as a library in your build path,

which would not be possible for me to add to AdvancedVanish without distributing the paid plugin for free.

I would recommend opening an issue there and probably referencing this issue in it.

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

RhinoCD commented 2 years ago

Heres the link to the page if needed too: https://builtbybit.com/resources/chatcontrol-red-format-filter-your-chat-1-chat-plugin-1-2-5-1-19-1-10-off.18217/

ElBananaa commented 2 years ago

Hey, I did try to work on implementing support for your plugin, however it seems like I am completely unable to get the plugin using jitpack. (see https://jitpack.io/#quantiom/AdvancedVanish) Is there an alternative repository I can get the plugin from?

quantiom commented 2 years ago

Hey, I did try to work on implementing support for your plugin, however it seems like I am completely unable to get the plugin using jitpack. (see https://jitpack.io/#quantiom/AdvancedVanish) Is there an alternative repository I can get the plugin from?

It seems like the project won't build on jitpack anymore, I think because of the network speed. I switched the repository to repsy and updated the instructions in the README. Let me know if it works for you.

ElBananaa commented 2 years ago

Hey, I did try to work on implementing support for your plugin, however it seems like I am completely unable to get the plugin using jitpack. (see https://jitpack.io/#quantiom/AdvancedVanish) Is there an alternative repository I can get the plugin from?

It seems like the project won't build on jitpack anymore, I think because of the network speed. I switched the repository to repsy and updated the instructions in the README. Let me know if it works for you.

Awesome, thanks! It works fine now :)

Btw, if you wish to get access to chatcontrol in order to hook with its api, feel free to send an email to kangarko matej@mineacademy.org. I believe he also plans to release the api publicly but I don't think he gave an eta for this.

quantiom commented 2 years ago

Hey, I did try to work on implementing support for your plugin, however it seems like I am completely unable to get the plugin using jitpack. (see https://jitpack.io/#quantiom/AdvancedVanish) Is there an alternative repository I can get the plugin from?

It seems like the project won't build on jitpack anymore, I think because of the network speed. I switched the repository to repsy and updated the instructions in the README. Let me know if it works for you.

Awesome, thanks! It works fine now :)

Btw, if you wish to get access to chatcontrol in order to hook with its api, feel free to send an email to kangarko matej@mineacademy.org. I believe he also plans to release the api publicly but I don't think he gave an eta for this.

If I were to do that, I would not be allowed to distribute it and other developers would not be able to build AdvancedVanish.

Also, I see that support has been added (https://github.com/kangarko/ChatControl-Red/issues/2085), so I will be closing this as completed. Thanks!

ElBananaa commented 2 years ago

Hey, I did try to work on implementing support for your plugin, however it seems like I am completely unable to get the plugin using jitpack. (see https://jitpack.io/#quantiom/AdvancedVanish) Is there an alternative repository I can get the plugin from?

It seems like the project won't build on jitpack anymore, I think because of the network speed. I switched the repository to repsy and updated the instructions in the README. Let me know if it works for you.

Awesome, thanks! It works fine now :) Btw, if you wish to get access to chatcontrol in order to hook with its api, feel free to send an email to kangarko matej@mineacademy.org. I believe he also plans to release the api publicly but I don't think he gave an eta for this.

If I were to do that, I would not be allowed to distribute it and other developers would not be able to build AdvancedVanish.

Also, I see that support has been added (kangarko/ChatControl-Red#2085), so I will be closing this as completed. Thanks!

Alright, thanks to you! I guess publishing the api is something Kangarko needs to work on quickly ^^