Closed timneutkens closed 6 years ago
Also add .next
to the gitignore, since it doesn't have to be committed.
And moved pages/App.js
and pages/Home.js
, because they're not pages they shouldn't be inside the pages
directory. If you keep them in pages
they'll be generated as page bundles inside .next
and will mess with the common modules calculation.
Merging #6 into master will not change coverage. The diff coverage is
n/a
.
@@ Coverage Diff @@
## master #6 +/- ##
=======================================
Coverage 87.12% 87.12%
=======================================
Files 3 3
Lines 101 101
Branches 27 27
=======================================
Hits 88 88
Misses 9 9
Partials 4 4
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 243ffed...7a5e992. Read the comment docs.
@timneutkens If you're using Node 10 locally, I think Yarn locally needs to be >= 1.7.0 to be compatible.
Thanks Tim!
🙌
Based on https://twitter.com/probablyup/status/1003857781894631424.
It was actually pretty easy, you weren't using
next/babel
, meaning Next.js's default preset wasn't used. The other issue was thatpreval
doesn't support Babel 7 yet, but this was fixable by usingDefinePlugin
.