search

quantmind / pulsar

Event driven concurrent framework for Python
BSD 3-Clause "New" or "Revised" License
1.86k stars 162 forks source link

A Flask router style Decoractor #277

Closed RyanKung closed 7 years ago

RyanKung commented 7 years ago

1) Should not use callable as parameter name; 2) Added a decorator to :class:Router for supporting flask like router.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling 73c2322fd8a41e20a6ca2b37eb8453b71705bd2f on RyanKung:master into on quantmind:master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling cc332997f2cfa7498d20d6442efb6b863f9c5ff2 on RyanKung:master into on quantmind:master.

lsbardel commented 7 years ago

Interesting method. How is one supposed to use it?

When adding new code the standard practice is to add an example if possible and, importantly, test coverage (without test nothing get merged).

RyanKung commented 7 years ago

@lsbardel Here is the unit test and examples.

lsbardel commented 7 years ago

Thanks for this. Can you make this pull request against the dev branch? It will go into pulsar 2.0

RyanKung commented 7 years ago

Hi @lsbardel , plz check https://github.com/quantmind/pulsar/pull/280 and https://github.com/quantmind/pulsar/pull/279 which is for dev branch

lsbardel commented 7 years ago

replaced by #279 agains the dev branch