quantombone / exemplarsvm

Ensemble of Exemplar-SVMs for Object Detection and Beyond
http://www.cs.cmu.edu/~tmalisie/projects/iccv11/index.html
MIT License
430 stars 155 forks source link

list_files_in_directory() should be able to only return images #46

Closed cvondrick closed 12 years ago

cvondrick commented 12 years ago

Since this is a computer vision toolkit, list_files_in_directory() should be able to only return images. This commit introduces an optional parameter that:

(Also, I wanted to see what 'pull request' did)

quantombone commented 12 years ago

Good idea on using the github system to push changes to submodules.

quantombone commented 12 years ago

I agree with the changes, let me pull it on my end too.

cvondrick commented 12 years ago

Oops, just realized that we both added the same feature here. I guess my submodule copy did not update properly. I'm not sure which solution is better -- regex or a more explicit extension enumeration.

quantombone commented 12 years ago

hmm, let me see what sort of conflicts my local version sees

quantombone commented 12 years ago

I'm not sure how your version is supposed to work...

quantombone commented 12 years ago

I see now, I will update comment.

quantombone commented 12 years ago

I just updated the comment once I figured out how to use it, I was specifying 'jpg' for the extension, but it only works with '.jpg'.

The comment can be seen here: https://github.com/quantombone/exemplarsvm/blob/master/util/list_files_in_directory.m

cvondrick commented 12 years ago

Cool, looks good!