Closed cvondrick closed 12 years ago
Good idea on using the github system to push changes to submodules.
I agree with the changes, let me pull it on my end too.
Oops, just realized that we both added the same feature here. I guess my submodule copy did not update properly. I'm not sure which solution is better -- regex or a more explicit extension enumeration.
hmm, let me see what sort of conflicts my local version sees
I'm not sure how your version is supposed to work...
I see now, I will update comment.
I just updated the comment once I figured out how to use it, I was specifying 'jpg' for the extension, but it only works with '.jpg'.
The comment can be seen here: https://github.com/quantombone/exemplarsvm/blob/master/util/list_files_in_directory.m
Cool, looks good!
Since this is a computer vision toolkit, list_files_in_directory() should be able to only return images. This commit introduces an optional parameter that:
(Also, I wanted to see what 'pull request' did)