ENH: Changed palette to work with colorblind users

quantopian / alphalens

Performance analysis of predictive (alpha) stock factors

http://quantopian.github.io/alphalens

Apache License 2.0

3.33k stars 1.14k forks source link

ENH: Changed palette to work with colorblind users #245

Closed mmargenot closed 6 years ago

luca-s commented 6 years ago

@mmargenot is your idea to remove hard coded G/R palettes and use matplotlib default? I like that but there are two issues:

two places still have hard coded values (G/R palette): here and here
the plots where all quantiles are shown at the same time can be easier to read with diverging color palette. So I would still hard code a diverging color palette in both here and here but I would change the G/R palette to something else.

luca-s commented 6 years ago

uhmmm, I thought again at that and I believe the three places where the palette is hard coded should stay the same as all of them need a diverging color palette. Easiest thing is to just replace the palette to something else. What is your view @mmargenot ?

EDIT: e.g. of alternative palettes are cool/warm or seismic

mmargenot commented 6 years ago

I can change the hardcoded spots to use a more friendly diverging color palette. I think I like cool/warm since it looks like the smoothest transition.