Open twiecki opened 6 years ago
Would it be correct to say that all that needs rewriting is this function in utils.py
(and any other docstrings here and there)?
That sounds straightforward; would you like me to put together a PR?
@eigenfoo Correct.
It would be great to have an alternative that goes back further in time. We can probably use the yahoo SPY returns for the past, and then forward-fill with the ones from google.
There's the IEX exchange API if it helps, and it requires no registration:
@twiecki I replaced Yahoo Finance with Quandl as shown here. Would you like me to update the default to use Quandl instead?
@jaycode Yes, that seems like a more stable source!
@twiecki Done, please resolve conflicts here: https://github.com/quantopian/empyrical/pull/89
There is also some minimal updates for Pyfolio module for this to work. See here: https://github.com/jaycode/pyfolio/commit/7ef8d27c4926f7cde2abcf6a15d0950450791633
A working example can be seen here: https://github.com/jaycode/pyfolio/blob/master/pyfolio/examples/single_stock_example.ipynb
Yahoo finance has been discontinued for good. Google is a fallback (albeit a bad one) but there's no reason to display a warning and confuse users: https://github.com/quantopian/pyfolio/issues/478#event-1345024064