quantopian / pyfolio

Portfolio and risk analytics in Python
https://quantopian.github.io/pyfolio
Apache License 2.0
5.64k stars 1.77k forks source link

[FIX]: Error when never ending drawdown #674

Closed dvdpedros closed 3 years ago

dvdpedros commented 3 years ago

When there's just one single never ending drawdown period the code breaks when computing the drawdown plots.

RichardDale commented 3 years ago

@dvdpedros I don't think Quantopian staff are involved with pyfolio/zipline/empyrical etc. any more. They've been in radio silence mode with no comments about the future of Zipline or their involvement (some moved to Robinhood, but no idea if Zipline is part of that deal).

Thankfully it's all open source.

@stefan-jansen has done a lot of great work with Zipline (Reloaded) to make it compatible with modern versions of Python and Pandas and actually bundled it all together into a stable release.

I recommend you test against https://github.com/stefan-jansen/pyfolio-reloaded and submit a pull request there if there's still an issue.

Cheers, Richard.

dvdpedros commented 3 years ago

Thanks for the detailed explanation Richard! I thought it was still maintained by people outside of the organization. I'll try Zipline then.

Thanks, David