search

quantopian / qgrid

An interactive grid for sorting, filtering, and editing DataFrames in Jupyter notebooks
Apache License 2.0
3.05k stars 421 forks source link

qgrid 1.2.0 and 1.3.0 is not available on jsdelivr.com or unpkg.com #309

Open DonJayamanne opened 4 years ago

DonJayamanne commented 4 years ago

Similar to issue https://github.com/quantopian/qgrid/issues/302

We Python extension in VS Code are adding support for ipywidgets in our implementation of notebooks. We found that users installing the latest version of qgrid from pypi will never be able to get this working as the script isn't available on cdn for the latest versions.

Thanks.

gerrymanoim commented 4 years ago

I believe this was addressed in https://github.com/quantopian/qgrid/pull/288

Upkg: https://unpkg.com/qgrid2@1.1.3/src/index.js Jsdelivr: https://www.jsdelivr.com/package/npm/qgrid2

Conda-forge is still an open issue for now.

DonJayamanne commented 4 years ago

Upkg: unpkg.com/qgrid2@1.1.3/src/index.js

I'm referring to 1.3.0 not 1.1.3.

gerrymanoim commented 4 years ago

Apologies - I'm not sure exactly what you mean.

Qgrid, the python package, is available on pypi: https://pypi.org/project/qgrid/ (1.3.1). Qgrid2, the supporting npm package, is available on npm: https://www.npmjs.com/package/qgrid2

DonJayamanne commented 4 years ago

Hmm, that will be an issue. Based on the docs here this will not work for those trying to add support for qgrid outside of jupyter notebooks/lab. Basically the name of the module & version must match the name of the js module & version.

Ie we'll end up looking for https://unpkg.com/qgrid@1.3.0/dist/index.js

We can make an exception for qgrid and hardcode the js package name to be qgrid2, however the versions must match.

@jasongrout Do you have any recommendations here. Or am I missing something here?

gerrymanoim commented 4 years ago

cc @richafrank @jbredeche - can we push the new js back to npm/qgrid and get the versions aligned?

thedanielforum commented 4 years ago

I would recommend adding publishing the package to npm as a step in the publish CI workflow. That way we don't have to rely on the maintainers to remember to manually publish the releases to npm.

https://github.com/quantopian/qgrid/actions?query=workflow%3A%22Publish+Python+%F0%9F%90%8D+distributions+%F0%9F%93%A6+to+PyPI%22

harrisliuwk commented 4 years ago

Hello, I recently found qgrid is so helpful in my exploratory data analysis workflow but unfortunately is incompatible with in-vscode jupyter notebook (even with jsdelivr.com and unpkg.com settings). It's good to know that if anyon is tracking this issue, many thanks.