search

quantorconsulting / mkdocs_build_plantuml

MkDocs plugin to help generate your plantuml images locally or remotely as files (NOT inline)
MIT License
57 stars 15 forks source link

Read multibytes language file (utf-8 encoding) in windows10 #10

Closed ByunghoJeon closed 9 months ago

ByunghoJeon commented 3 years ago

Hi. I'm really useful this plugin.

An error occurs when creating a file containing Korean characters.(UTF-8 encoded) I explicit pass encoding=utf-8 parameter, it works.

https://github.com/christo-ph/mkdocs_build_plantuml/blob/7f037be4ee23c8f6a65b3cf2851ed8c64322f509/mkdocs_build_plantuml_plugin/plantuml.py#L58

 with open(os.path.join(diagram.directory, diagram.file), "r", encoding="utf-8") as f:

thank you.

christo-ph commented 3 years ago

Hi, thanks for the report. Are you able to provide a merge request?

christo-ph commented 9 months ago

Included in 1.8.0