search

quantorconsulting / mkdocs_build_plantuml

MkDocs plugin to help generate your plantuml images locally or remotely as files (NOT inline)
MIT License
57 stars 15 forks source link

Add support for include folders #12

Closed yababer closed 2 years ago

yababer commented 2 years ago

It would be awesome if there was support to add other folders to search for !include files.

Something similar to support in vscode: https://github.com/qjebbs/vscode-plantuml

plantuml.includepaths: Specifies the include paths besides source folder and the diagramsRoot.
christo-ph commented 2 years ago

Hi @yababer I am currently too busy to add functionality here.

Accepting Merge Requests.

yababer commented 2 years ago

sounds good, if I have a bit of time this weekend I will push something up.

yababer commented 2 years ago

@christo-ph I had a few minutes and added this feature. Can you give me access so I can create a pr.

yababer commented 2 years ago

We ended up forking the plugin in our local repo and made changes there. Let us know if you want to push it back here, I will close this issue for now.

christo-ph commented 2 years ago

Sorry, I missed you last message. You should simply make an merge request, this should work.

christo-ph commented 2 years ago

To work properly, you should fork from GitHub directly. Work on the code and then make the pull request. I suppose, you were working by cloning this repo?

christo-ph commented 2 years ago

Anyway, you should now be able to push

christo-ph commented 2 years ago

Thanks @yababer , I merged your pull request.

Would be nice if you also add the new behavior to the README.md in the root folder.