quantum-compiler / quartz

The Quartz Quantum Compiler
Apache License 2.0
78 stars 19 forks source link

[Refactor] Rename "DAG" to "CircuitSeq" #60

Open xumingkuan opened 2 years ago

xumingkuan commented 2 years ago

The name DAG is a bit confusing in that the term "DAG" is not the best name to describe it. It is actually the "Sequence Representation" in our paper (https://arxiv.org/pdf/2204.09033.pdf, page 4, section 3.1).

I am considering renaming it to CircuitSeq to avoid confusion. Here is the complete renaming plan:

Do you think the new names are clear? Any suggestions are welcome.


Edit after merging #61: the class name is renamed, but there are a lot of variable names still being dag. Help wanted for renaming these to seq :)

xumingkuan commented 2 years ago

If there are no suggestions, I will start refactoring.

jiazhihao commented 2 years ago

These renames look good to me. We should also rename TASOGraph to Graph, since our current graph implementation is quite different from the original TASOGraph. @zikun-li @Co1lin What do you think?

xumingkuan commented 2 years ago

These renames look good to me. We should also rename TASOGraph to Graph, since our current graph implementation is quite different from the original TASOGraph. @zikun-li @Co1lin What do you think?

I think this is already renamed. But the file name is still tasograph/tasograph.h -- shall we also rename that to graph/graph.h?