Expose Telemetry Metrics

quantum-elixir / quantum-core

:watch: Cron-like job scheduler for Elixir

https://hexdocs.pm/quantum/

Apache License 2.0

2.32k stars 148 forks source link

Expose Telemetry Metrics #415

Closed maennchen closed 4 years ago

maennchen commented 5 years ago

Expose Metrics via Telemetry

mrmarcsmith commented 4 years ago

@maennchen I'm happy to explore opening a PR for this. Is this something you have started? if not, Is there any chance you could give me a shove in the right direction as far as a high level plan? You know this project better than anyone so a little bit of help from you could save me a LOT of time.

mrmarcsmith commented 4 years ago

@maennchen if you have time, a quick reply could help me get started on this.

maennchen commented 4 years ago

@mrmarcsmith Sorry, i don't really have time right now. I'm on vacation until next week.

It'd be awesome to get a PR with this feature.

I have thought about this at some point. I thought that at least the following events should be recorded:

add job
delete job
update job
job execution (including return value / error / execution time)

The first three should probably be added to the JobBroadcaster module and the execution in the Executor module.

mrmarcsmith commented 4 years ago

That should be enough to get me started! Thank you for replying while on vacation.

maennchen commented 4 years ago

Replaced by #453

maennchen commented 4 years ago

@mrmarcsmith Released as v3.2.0 :heart:

mrmarcsmith commented 4 years ago

Thank you @maennchen!