quantum-elixir / quantum-core

:watch: Cron-like job scheduler for Elixir
https://hexdocs.pm/quantum/
Apache License 2.0
2.32k stars 148 forks source link

feat: Handles task failures by returning a value #445

Closed isaacsanders closed 4 years ago

isaacsanders commented 4 years ago

Right now, a value is not always returned, as exits, exceptions, and thrown values are not handled inside the task.

This ensures a value is always returned.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 92f26a3ce27245299d6eb569fa5f8a29ce9c32dc-PR-445


Files with Coverage Reduction New Missed Lines %
lib/quantum/executor.ex 1 96.55%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 7d97024030b1b0b6872e54707932df5691fc9a45: -0.1%
Covered Lines: 296
Relevant Lines: 338

💛 - Coveralls
maennchen commented 4 years ago

Thanks @isaacsanders ❤️

I think it would be better to log that an exception was thrown instead of the yielded result.