quantum-elixir / quantum-core

:watch: Cron-like job scheduler for Elixir
https://hexdocs.pm/quantum/
Apache License 2.0
2.32k stars 148 forks source link

Uses logger metadata #462

Closed isaacsanders closed 4 years ago

isaacsanders commented 4 years ago

Fixes #460

I have replaced the uses of dynamic messages in debug logs with static messages with dynamic logger metadata.

coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 2c7d0873d9770c05c425426eea4369e151499018-PR-462


Files with Coverage Reduction New Missed Lines %
lib/quantum/job.ex 1 94.12%
lib/quantum/executor.ex 6 75.86%
lib/quantum/execution_broadcaster.ex 10 65.52%
<!-- Total: 17 -->
Totals Coverage Status
Change from base Build 603146e5da35c85bad7043fb15eab44360dea7c1: -5.3%
Covered Lines: 295
Relevant Lines: 360

💛 - Coveralls
coveralls commented 4 years ago

Pull Request Test Coverage Report for Build 1e831380349232b66b3227be9463fe8c70b48899-PR-462


Totals Coverage Status
Change from base Build 603146e5da35c85bad7043fb15eab44360dea7c1: -0.6%
Covered Lines: 312
Relevant Lines: 360

💛 - Coveralls
maennchen commented 4 years ago

@isaacsanders Thanks a lot ❤️

I‘ll have a detailed look on monday.