quantum-elixir / quantum-core

:watch: Cron-like job scheduler for Elixir
https://hexdocs.pm/quantum/
Apache License 2.0
2.3k stars 147 forks source link

Log exception with crash_reason #464

Closed iloveitaly closed 3 years ago

iloveitaly commented 3 years ago

Thanks for the amazing work on this package! Super helpful.

I ran into two issues:

Here's what I found:

This change fixes both of these problems.

I've submitted a proposal to elixir-lang to get this function included in the stdlib: https://groups.google.com/g/elixir-lang-core/c/pWz-uTVMEVM

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 450077e6f9a3a2d438333fa1219f5354a4553312-PR-464


Totals Coverage Status
Change from base Build 3ac7984f4bfca2b47fb9d36e70e56fcaa302dbd6: 1.3%
Covered Lines: 317
Relevant Lines: 365

💛 - Coveralls
maennchen commented 3 years ago

Thanks @iloveitaly for the PR!

Could you also add a test for that new log message?

iloveitaly commented 3 years ago

@maennchen done!