Closed iloveitaly closed 3 years ago
Totals | |
---|---|
Change from base Build 3ac7984f4bfca2b47fb9d36e70e56fcaa302dbd6: | 1.3% |
Covered Lines: | 317 |
Relevant Lines: | 365 |
Thanks @iloveitaly for the PR!
Could you also add a test for that new log message?
@maennchen done!
Thanks for the amazing work on this package! Super helpful.
I ran into two issues:
Here's what I found:
info
. I'd expect most deployments to use a non-info log level.debug
log but instead should use something likeerror
.crash_reason
to exist in your log metadata for the log message to be treated as an exception. Here's an example implementation in broadwayThis change fixes both of these problems.
I've submitted a proposal to elixir-lang to get this function included in the stdlib: https://groups.google.com/g/elixir-lang-core/c/pWz-uTVMEVM