quantum-elixir / quantum-core

:watch: Cron-like job scheduler for Elixir
https://hexdocs.pm/quantum/
Apache License 2.0
2.32k stars 148 forks source link

Tests are not executed properly #466

Closed pnezis closed 3 years ago

pnezis commented 3 years ago

When executing mix test I am getting the following errors.

 Quantum.ExecutionBroadcasterTest: failure on setup_all callback, all tests have been invalidated
     ** (EXIT from #PID<0.422.0>) exited in: ExUnit.CaptureLog.remove_capture(#PID<0.490.0>)
         ** (EXIT) {:error, :module_not_found}

Quantum.ExecutorTest: failure on setup_all callback, all tests have been invalidated
     ** (EXIT from #PID<0.3948.0>) exited in: ExUnit.CaptureLog.remove_capture(#PID<0.3949.0>)
         ** (EXIT) {:error, :module_not_found}

The same errors appear in all latest coveralls pipelines. Notice that all remaining tests in the modules with issues are never executed and the tests appear as successful

The culprits are the following tests. If I comment them out all other tests run without issues:

- Quantum.ExecutionBroadcasterTest: "invalid timezone will not create a crash"
- Quantum.ExecutorTest: "start_link/3 logs error"
- Quantum.ExucutorTest: "start_link/3 releases lock on error"
maennchen commented 3 years ago

Hmm. There seems to be an elixir issue about it: https://github.com/elixir-lang/elixir/issues/8507

pnezis commented 3 years ago

This seems to be introduced by the addition of logger metadata #462.

image

Test output on the previous PR (#459):

image