quantum-elixir / quantum-core

:watch: Cron-like job scheduler for Elixir
https://hexdocs.pm/quantum/
Apache License 2.0
2.3k stars 147 forks source link

feat: Use `:telemetry.span/3` #480

Closed isaacsanders closed 3 years ago

isaacsanders commented 3 years ago

There doesn't seem to be a clear reason to not use the proper span function.

I figured I would do the legwork here.

isaacsanders commented 3 years ago

There seems to be an issue with the build process.

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 6d46dc69994cca31ff29c7b9d3f107c7b8e9811b-PR-480


Files with Coverage Reduction New Missed Lines %
lib/quantum/executor.ex 1 93.33%
<!-- Total: 1 -->
Totals Coverage Status
Change from base Build 7d24f247e4b000a4d050c157a30b01cc8cb1864d: -0.2%
Covered Lines: 308
Relevant Lines: 357

💛 - Coveralls
maennchen commented 3 years ago

Thanks a lot @isaacsanders :heart: