Fix telemetry not support v1.0

quantum-elixir / quantum-core

:watch: Cron-like job scheduler for Elixir

https://hexdocs.pm/quantum/

Apache License 2.0

2.32k stars 148 forks source link

Fix telemetry not support v1.0 #483

Closed wingyplus closed 3 years ago

wingyplus commented 3 years ago

The patch try to make this library support telemetry v1.0. Currently, it doesn't because it contraint between [0.4.3, 1.0.0). Fix by using or constraint to support both version.

maennchen commented 3 years ago

Thanks for your PR @wingyplus :heart:

Can you correct the requirement so that for example 0.4.1 does not match?

coveralls commented 3 years ago

Pull Request Test Coverage Report for Build 201b3ca71b0ee6665dd8f1fe57bf9a65c38bef66-PR-483

0 of 0 changed or added relevant lines in 0 files are covered.
2 unchanged lines in 1 file lost coverage.
Overall coverage decreased (-0.3%) to 85.994%

Files with Coverage Reduction	New Missed Lines	%
lib/quantum/executor.ex	2	90.0%
<!--	Total:	2		-->

Totals
Change from base Build 91a4df2490b9ebf01e6a46299920cd0550a89f62:	-0.3%
Covered Lines:	307
Relevant Lines:	357

💛 - Coveralls

wingyplus commented 3 years ago

@maennchen Oh, that's my mistake. We should constraint to ~> 0.4.3 or ~> 1.0 because quantum use :telemetry.span. The patch is fix.

wingyplus commented 3 years ago

@maennchen Can we merge this one?

maennchen commented 3 years ago

@wingyplus Oops, sorry for the delay.

maennchen commented 3 years ago

@wingyplus Released as v3.4.0

wingyplus commented 3 years ago

@maennchen Thank you. 🙇‍♂️