quantumjot / btrack

Bayesian multi-object tracking
https://btrack.readthedocs.io
MIT License
311 stars 50 forks source link

Undo linting pr due to errors it introduced #213

Closed p-j-smith closed 1 year ago

p-j-smith commented 1 year ago

Fixes #211

I've reverted the changes done by the commits in #204

Doing a git diff with the last commit before that pr (git diff 0c61b835b3b2468b8e8029d250499cca15ba6927) shows the following:

added: .github/workflows/update_project_board.yml
-----------------------------------------------
@ .github/workflows/update_project_board.yml:4 @
+name: Add New Issues to Project Board

+on:
+  issues:
+    types:
+      - opened

+jobs:
+  update-project-board:
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/add-to-project@v0.4.1
+        with:
+          project-url: https://github.com/orgs/lowe-lab-ucl/projects/1
+          github-token: ${{ secrets.ADD_TO_PROJECT_PAT }}
-----------------------------------------------
modified: tests/test_config.py
-----------------------------------------------
@ tests/test_config.py:64 @ def test_import_config():
     assert isinstance(cfg, btrack.config.TrackerConfig)

+def test_config_to_json():
+    """Test that a config can be converted to json format without raising an error"""
+    cfg = btrack.config.load_config(CONFIG_FILE)
+    cfg.json()

i.e the only difference between the current code and the code at commit 0c61b835b3b2468b8e8029d250499cca15ba6927 is the addition of the workflow to add issues to the common project board and a test I've added to check that TrackerConfig can be converted to json

P.S sorry for breaking things in #204

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 83.50% and project coverage change: -1.03 :warning:

Comparison is base (7594543) 88.56% compared to head (05b2301) 87.54%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #213 +/- ## ========================================== - Coverage 88.56% 87.54% -1.03% ========================================== Files 19 19 Lines 1522 1549 +27 ========================================== + Hits 1348 1356 +8 - Misses 174 193 +19 ``` | [Impacted Files](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) | Coverage Δ | | |---|---|---| | [btrack/dataio.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2RhdGFpby5weQ==) | `0.00% <0.00%> (ø)` | | | [btrack/io/\_\_init\_\_.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL19faW5pdF9fLnB5) | `100.00% <ø> (ø)` | | | [btrack/datasets.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2RhdGFzZXRzLnB5) | `58.82% <42.85%> (-11.55%)` | :arrow_down: | | [btrack/io/hdf.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL2hkZi5weQ==) | `82.75% <74.35%> (-0.45%)` | :arrow_down: | | [btrack/io/exporters.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL2V4cG9ydGVycy5weQ==) | `83.33% <75.00%> (ø)` | | | [btrack/io/utils.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL3V0aWxzLnB5) | `90.69% <78.57%> (-0.22%)` | :arrow_down: | | [btrack/libwrapper.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2xpYndyYXBwZXIucHk=) | `97.05% <80.00%> (ø)` | | | [btrack/btypes.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2J0eXBlcy5weQ==) | `82.29% <84.61%> (-1.28%)` | :arrow_down: | | [btrack/optimise/optimiser.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL29wdGltaXNlL29wdGltaXNlci5weQ==) | `83.72% <88.23%> (-2.70%)` | :arrow_down: | | [btrack/utils.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL3V0aWxzLnB5) | `90.17% <88.88%> (-2.13%)` | :arrow_down: | | ... and [10 more](https://codecov.io/gh/quantumjot/BayesianTracker/pull/213?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/BayesianTracker/213 Updated: 2023-03-09T08:55:02.443220

p-j-smith commented 1 year ago

I've rebased this branch onto main to include the changes from #205

paddyroddy commented 1 year ago

Seeing as we suspect this broke something I'm going to merge now