quantumjot / btrack

Bayesian multi-object tracking
https://btrack.readthedocs.io
MIT License
310 stars 50 forks source link

Move to `pyproject.toml` only structure #214

Closed paddyroddy closed 1 year ago

paddyroddy commented 1 year ago

Fixes #212. Needs testing.

paddyroddy commented 1 year ago

Linting failure is expected due to #213

p-j-smith commented 1 year ago

Linting failure is expected due to https://github.com/quantumjot/BayesianTracker/pull/213

Maybe it's best not to add new linting tools or rules in this pr as we'll end up with the same problem as in #213. Can you base the pyproject.toml on the current setup.cfg in main rather than the one from #213?

paddyroddy commented 1 year ago

Can you reply to me on slack?

paddyroddy commented 1 year ago

Linting failure is expected due to #213

Maybe it's best not to add new linting tools or rules in this pr as we'll end up with the same problem as in #213. Can you base the pyproject.toml on the current setup.cfg in main rather than the one from #213?

I have pulled the lastest main, that is what I rebased on.

paddyroddy commented 1 year ago

I've only added toml-sort-fix as that helps me ensure it is valid TOML format

paddyroddy commented 1 year ago

I now get what you mean - it wasn't clear - I have removed ruff. However, flake8 isn't compatible with pyproject.toml - see PyCQA/flake8#234. So I've had to add a .flake8 for now.

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -4.62 :warning:

Comparison is base (696ee5b) 87.24% compared to head (5c1467d) 82.63%.

:exclamation: Current head 5c1467d differs from pull request most recent head 43c464a. Consider uploading reports for the commit 43c464a to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #214 +/- ## ========================================== - Coverage 87.24% 82.63% -4.62% ========================================== Files 17 19 +2 Lines 1427 1549 +122 Branches 0 269 +269 ========================================== + Hits 1245 1280 +35 - Misses 182 193 +11 - Partials 0 76 +76 ``` | [Impacted Files](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) | Coverage Δ | | |---|---|---| | [btrack/io/exporters.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL2V4cG9ydGVycy5weQ==) | `72.22% <0.00%> (-11.12%)` | :arrow_down: | | [btrack/io/hdf.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL2hkZi5weQ==) | `72.79% <0.00%> (-9.97%)` | :arrow_down: | | [btrack/napari/reader.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL25hcGFyaS9yZWFkZXIucHk=) | `72.41% <0.00%> (-6.90%)` | :arrow_down: | | [btrack/io/\_localization.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL19sb2NhbGl6YXRpb24ucHk=) | `86.04% <0.00%> (-5.82%)` | :arrow_down: | | [btrack/core.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2NvcmUucHk=) | `82.95% <0.00%> (-5.39%)` | :arrow_down: | | [btrack/io/utils.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL3V0aWxzLnB5) | `86.04% <0.00%> (-4.66%)` | :arrow_down: | | [btrack/optimise/optimiser.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL29wdGltaXNlL29wdGltaXNlci5weQ==) | `79.06% <0.00%> (-4.66%)` | :arrow_down: | | [btrack/config.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2NvbmZpZy5weQ==) | `91.93% <0.00%> (-3.23%)` | :arrow_down: | | [btrack/models.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL21vZGVscy5weQ==) | `89.76% <0.00%> (-3.15%)` | :arrow_down: | | [btrack/btypes.py](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2J0eXBlcy5weQ==) | `80.86% <0.00%> (-1.44%)` | :arrow_down: | | ... and [3 more](https://codecov.io/gh/quantumjot/BayesianTracker/pull/214?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

paddyroddy commented 1 year ago

Have gone through and made 3.10 the default everywhere, and removed references to 3.7.

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/BayesianTracker/214 Created: 2023-03-09T16:55:06.242845

paddyroddy commented 1 year ago

Drop in coverage due to checking branching - i.e. expected.