Closed p-j-smith closed 1 year ago
Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/btrack/224 Updated: 2023-03-13T11:37:01.975530
I went through the fixes for each rule individually, running tests after each change, and I'm fairly certain the there are no changes to any functionality or logic.
I've ignored some rules for certain lines e.g.:
Patch coverage: 77.63
% and project coverage change: +0.27
:tada:
Comparison is base (
ea0850b
) 82.50% compared to head (888954d
) 82.78%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
I had to change the way the year is determined in the docs setup because ruff wasn't happy:
docs/conf.py:25:21: DTZ011 The use of `datetime.date.today()` is not allowed, use `datetime.datetime.now(tz=).date()` instead
Looks like you've committed .hypothesis/unicode_data/13.0.0/charmap.json.gz
!
Looks like you've committed
.hypothesis/unicode_data/13.0.0/charmap.json.gz
!
woops! I'll remove
I assume the codecov
thing isn't an issue?
I assume the codecov thing isn't an issue?
I guess not, maybe it's because the formatting split some untested code across multiple lines, so now there are more untested lines?
Fixes #220
Hopefully a more manageable and less destructive version of #204. Only introducing Ruff here - not prettier, and not adding support for tox 4 - this can be done in a separate pr
fix = false
- use Ruff as a linter rather than a formatter for now. This means linting will currently fail from Ruff complaints. I'll go through each of the rules and add either fix them manually or add them to thefixable
list, and check the tests still passEdit: I've fixed all the linting complaints and removed the
fix
restrictions for Ruff