Closed paddyroddy closed 1 year ago
Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/btrack/231 Updated: 2023-03-21T12:37:04.473660
Patch coverage has no change and project coverage change: -0.13
:warning:
Comparison is base (
de6e9b8
) 82.78% compared to head (1589d64
) 82.65%.
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
@quantumjot can you test the deployment? Perhaps when #228 is merged, seeing as you are bumping the version?
This is a solution to solving #192, however we have not used
cibuildwheels
. Some issues on that to follow (#235), and I'll explain why here.Using
cibuildwheels
to do everything explained in #192 proved quite complex and would involve a lot of changes. This PR has the minimal changes which respect the current workflow but remove the libraries fromgit
. I will raise an issue separately about Windows shortly (#234). We (@p-j-smith and I) hadn't realised that the Windows binary was cross-compiled, so a bit of pain trying to fix that.The main thing done here is that now where we previously had a testing workflow and a deployment workflow, we now build the C++, test the python and deploy in a single workflow. This should ensure we don't have a failing deployment.