quantumjot / btrack

Bayesian multi-object tracking
https://btrack.readthedocs.io
MIT License
310 stars 50 forks source link

Build wheels on earlier OS versions & verify binaries are included #300

Closed paddyroddy closed 1 year ago

paddyroddy commented 1 year ago

Add an additional step which installs the latest from TestPyPI and creates a BayesianTracker instance to verify if the binary is included. This then leads to a step which only uploads to PyPI.

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/btrack/300 Updated: 2023-04-18T15:27:47.255365

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.16 :tada:

Comparison is base (9b54ccb) 83.92% compared to head (b508f3c) 84.09%.

:exclamation: Current head b508f3c differs from pull request most recent head aec964a. Consider uploading reports for the commit aec964a to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #300 +/- ## ========================================== + Coverage 83.92% 84.09% +0.16% ========================================== Files 30 30 Lines 1904 1905 +1 Branches 295 295 ========================================== + Hits 1598 1602 +4 + Misses 219 216 -3 Partials 87 87 ``` | [Impacted Files](https://codecov.io/gh/quantumjot/btrack/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) | Coverage Δ | | |---|---|---| | [btrack/btypes.py](https://codecov.io/gh/quantumjot/btrack/pull/300?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2J0eXBlcy5weQ==) | `82.54% <100.00%> (+1.41%)` | :arrow_up: | ... and [1 file with indirect coverage changes](https://codecov.io/gh/quantumjot/btrack/pull/300/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

paddyroddy commented 1 year ago

To test in docker locally, I am running the following https://github.com/quantumjot/btrack/issues/296#issuecomment-1511006705

paddyroddy commented 1 year ago

I'm going to try a few more things. Reverting back to draft.

paddyroddy commented 1 year ago

Okay, so I've tried a few things:

paddyroddy commented 1 year ago

Ready for review @quantumjot @p-j-smith

quantumjot commented 1 year ago

Looks good to me - although I have to admit that the level of workflow wrangling here is beyond my comprehension.

Regarding the supported versions, I think this is fine. One of the reasons why btrack<=0.5.0 worked for others may be that we built against an earlier version of Eigen using C++11. Do we want to add a line to the README to indicate this change?

paddyroddy commented 1 year ago

Have added a comment on Eigen