Closed paddyroddy closed 1 year ago
Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/btrack/300 Updated: 2023-04-18T15:27:47.255365
Patch coverage: 100.00
% and project coverage change: +0.16
:tada:
Comparison is base (
9b54ccb
) 83.92% compared to head (b508f3c
) 84.09%.:exclamation: Current head b508f3c differs from pull request most recent head aec964a. Consider uploading reports for the commit aec964a to get more accurate results
:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
To test in docker
locally, I am running the following https://github.com/quantumjot/btrack/issues/296#issuecomment-1511006705
I'm going to try a few more things. Reverting back to draft.
Okay, so I've tried a few things:
macos-11
and in reality we cannot. GitHub did have macos-10.15
but it has been deprecated. We will have to state that we do not support older architectures. Given that 11
came out on 12 November 2020
I don't think this is unreasonable (see https://en.wikipedia.org/wiki/MacOS_version_history#Releases).ubuntu-20.04
and in reality we cannot. Even the manylinux
container project only supports from 20.04
. In theory, this wheel should work on any distro, although we cannot completely guarantee that.cvxopt
still doesn't have ARM wheels cvxopt/cvxopt#234 (this has blocked me). The GitHub runners are all x86_64
https://github.com/orgs/community/discussions/25319#discussioncomment-3247468. If we can get cibuildwheels
working #235 then this should be possible.Ready for review @quantumjot @p-j-smith
Looks good to me - although I have to admit that the level of workflow wrangling here is beyond my comprehension.
Regarding the supported versions, I think this is fine. One of the reasons why btrack<=0.5.0 worked for others may be that we built against an earlier version of Eigen using C++11. Do we want to add a line to the README to indicate this change?
Have added a comment on Eigen
Add an additional step which installs the latest from TestPyPI and creates a
BayesianTracker
instance to verify if the binary is included. This then leads to a step which only uploads to PyPI.