quantumjot / btrack

Bayesian multi-object tracking
https://btrack.readthedocs.io
MIT License
309 stars 50 forks source link

Refactor `segmentation_to_objects` #304

Closed quantumjot closed 1 year ago

quantumjot commented 1 year ago

This PR refactors a critical function segmentation_to_objects:

quantumjot commented 1 year ago

These changes are to enable @ania-m-b to do some "advanced" analysis.

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/btrack/304 Updated: 2023-04-20T11:30:19.635085

quantumjot commented 1 year ago

@paddyroddy and @p-j-smith - this should also help with some aspects of running this from the napari plugin

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 95.74% and project coverage change: +0.37 :tada:

Comparison is base (146419f) 84.09% compared to head (07721e5) 84.47%.

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #304 +/- ## ========================================== + Coverage 84.09% 84.47% +0.37% ========================================== Files 30 30 Lines 1905 1932 +27 Branches 295 295 ========================================== + Hits 1602 1632 +30 + Misses 216 215 -1 + Partials 87 85 -2 ``` | [Impacted Files](https://codecov.io/gh/quantumjot/btrack/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) | Coverage Δ | | |---|---|---| | [btrack/io/\_localization.py](https://codecov.io/gh/quantumjot/btrack/pull/304?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2lvL19sb2NhbGl6YXRpb24ucHk=) | `91.89% <95.74%> (+6.17%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

quantumjot commented 1 year ago

Thanks for the review @paddyroddy - I think I took care of everything.