quantumjot / btrack

Bayesian multi-object tracking
https://btrack.readthedocs.io
MIT License
312 stars 49 forks source link

Fix mac silicon for napari #306

Closed paddyroddy closed 1 year ago

paddyroddy commented 1 year ago

I've been struggling to develop the whole time and realised stuff is on conda now which wasn't before, so have worked it out and written it down. h5py seems to now be universal on PyPI, so no longer needed in the environment.yaml.

Related #217. Still think it would better to remove the environment.yaml file in favour of documenting the fact that you just need to install those packages from PyPI. For example, for this to work I've had to add pyqt to environment.yaml, whereas in pyproject.toml we are making pyqt only required when doing pip install btrack[napari].

deprecated-napari-hub-preview-bot[bot] commented 1 year ago

Preview page for your plugin is ready here: https://preview.napari-hub.org/quantumjot/btrack/306 Updated: 2023-04-26T14:59:33.576102

codecov-commenter commented 1 year ago

Codecov Report

Patch coverage: 80.76% and project coverage change: +0.03 :tada:

Comparison is base (666821e) 84.47% compared to head (33e7ed8) 84.50%.

:exclamation: Current head 33e7ed8 differs from pull request most recent head 6a039df. Consider uploading reports for the commit 6a039df to get more accurate results

:mega: This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #306 +/- ## ========================================== + Coverage 84.47% 84.50% +0.03% ========================================== Files 30 30 Lines 1932 1943 +11 Branches 294 293 -1 ========================================== + Hits 1632 1642 +10 - Misses 215 217 +2 + Partials 85 84 -1 ``` | [Impacted Files](https://codecov.io/gh/quantumjot/btrack/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe) | Coverage Δ | | |---|---|---| | [btrack/utils.py](https://codecov.io/gh/quantumjot/btrack/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL3V0aWxzLnB5) | `80.48% <58.33%> (-2.40%)` | :arrow_down: | | [btrack/constants.py](https://codecov.io/gh/quantumjot/btrack/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2NvbnN0YW50cy5weQ==) | `100.00% <100.00%> (ø)` | | | [btrack/libwrapper.py](https://codecov.io/gh/quantumjot/btrack/pull/306?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=Alan+R+Lowe#diff-YnRyYWNrL2xpYndyYXBwZXIucHk=) | `100.00% <100.00%> (+3.77%)` | :arrow_up: |

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

quantumjot commented 1 year ago

I think it's fine to remove environment.yml now. I never use it nowadays anyway, and these new instructions in the README are clear

paddyroddy commented 1 year ago

Have decided to remove the environment.yml and improve the docs etc for installation.

Fixes #217.

paddyroddy commented 1 year ago

Fixes #218.

paddyroddy commented 1 year ago

@quantumjot and @p-j-smith can you have a look at this again please?