quantumjot / btrack

Bayesian multi-object tracking
https://btrack.readthedocs.io
MIT License
310 stars 50 forks source link

[FEATURE REQUEST] Set default value of p(not track) #372

Closed quantumjot closed 11 months ago

quantumjot commented 11 months ago

should be: 0.1

p-j-smith commented 11 months ago

Sorry you may have missed it, but I mentioned in #357 that this widget has:

...a default value of 0.001, as this is the value used by the cell and particle example configs (which we load into the plugin at launch)

Would it be possible to update the values in the example configs, just so we don't have to maintain a separate set of defaults?

paddyroddy commented 11 months ago

image image I've changed in both for now. But it doesn't update in the widget. Any idea @p-j-smith?

p-j-smith commented 11 months ago

I've changed in both for now. But it doesn't update in the widget. Any idea @p-j-smith?

the cell and particle example configs are loaded when the plugin is launched, and the cell config is then selected. This then sets all the widget values (effectively setting the defaults)

We could either update the example configs, or reset the default after loading the example cell config

paddyroddy commented 11 months ago

Okay but for now I've changed it everywhere so why is it showing 0.001? Checkout my PR and see for yourself

p-j-smith commented 11 months ago

The defaults are set by the cell config we load from the datasets module:

https://github.com/quantumjot/btrack/blob/003407e00569e3718aceacc849036835f477a121/btrack/napari/main.py#L52-L56

So we could either update the example configs, or reset the default after loading the example cell config

paddyroddy commented 11 months ago

There you go. Related #375

p-j-smith commented 11 months ago

There you go. Related https://github.com/quantumjot/btrack/issues/375

I think the ones in models/ aren't being used. We using the datasets module to load the example configs, which takes them from:

https://github.com/quantumjot/btrack/blob/003407e00569e3718aceacc849036835f477a121/btrack/datasets.py#L11

paddyroddy commented 11 months ago

I'm closing this in favour of lowe-lab-ucl/btrack-examples#1