quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.26k stars 1.01k forks source link

Add confusion maps support to PauliMeasurementGate #5571

Open tanujkhattar opened 2 years ago

tanujkhattar commented 2 years ago

https://github.com/quantumlib/Cirq/pull/5480 added support for confusion maps to measurement gates. The feature request is to extend this support to cirq.PauliMeasurementGate as well.

P2 - we should do it in the next couple of quarters

Tarun-Kumar07 commented 1 year ago

@tanujkhattar , can I work on this issue? I am new to open source, in case of any queries where can I reach out for help ?

95-martin-orion commented 1 year ago

@tanujkhattar was this resolved by #5480? If so, apologies for not closing it at that time.

Welcome to the community @Tarun-Kumar07!

Tarun-Kumar07 commented 1 year ago

@95-martin-orion and @tanujkhattar , the constructors in pauli_measurement_gates.py don't take confusion map as parameter, but they are taken in measurement_gate.py.

So is this issue still open ?

95-martin-orion commented 1 year ago

{...} the constructors in pauli_measurement_gates.py don't take confusion map as parameter, but they are taken in measurement_gate.py.

You are absolutely right - I glossed over the fact that this issue is specific to Pauli measurements. I've been away from Cirq for a while, but I suspect this is still open and useful to have. @tanujkhattar can confirm, but until then you're welcome to start working on it. Thanks!

As far as questions go, you can join the cirq-dev googlegroup to get an invite to the public Cirq sync. The meeting is a good place to ask questions, and the associated doc has links to other support options.

Tarun-Kumar07 commented 1 year ago

Great, I will start looking into this

Thank you @95-martin-orion !!

Kirs67 commented 1 year ago

Hi, @Tarun-Kumar07 Are you still working on this issue, or is it free to take?

Tarun-Kumar07 commented 1 year ago

@Kirs67 I'm working on this issue

tanujkhattar commented 1 year ago

@Tarun-Kumar07 Can you please share a summary of the progress you've made so far and whether you have any questions? Also, any estimate of by when you might be able to send a PR ? This has been open for a while now and it'll be good to gain some traction here.

Tarun-Kumar07 commented 1 year ago

Hi @tanujkhattar, Can you assign this issue to me ?

Progress :

Doubts :

Estimate for PR :

PS - I am new to quantum computing and Cirq, will take some time to get to speed 😄 .

MZuhairKhan commented 4 months ago

Hey! I am interested in this project. Could you assign it to me?

NoureldinYosri commented 4 months ago

@MZuhairKhan done, thanks for your help with this task

MZuhairKhan commented 4 months ago

Hey @NoureldinYosri, I think I have the implementation mostly done (I hope). Do I also need to modify the decompose function to use the confusion matrix?

daxfohl commented 4 months ago

Yes, defer_measurements uses this decompose function.