quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.24k stars 1.01k forks source link

Add at least one output to the start notebook #6360

Closed senecameeks closed 10 months ago

senecameeks commented 10 months ago

The tensorflow import tool will skip trying to run any notebook that has any output, and instead publishes the notebook as is to the website. This includes a print of a simple circuit to get around the import tool.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

senecameeks commented 10 months ago

To clarify-- currently the import tool tries to execute the notebook since there is no output and fails (the engine api isn't enabled to run for the tensorflow-testing project). When it fails, the notebook isn't published to the website If there is any output included (what the PR does and what we want), the import tool will skip trying to execute the notebook and publish it as is.

senecameeks commented 10 months ago

cc: @MichaelBroughton , my comment above might be helpful for future attempts to import notebooks to the website.

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (b5b3b74) 97.84% compared to head (21f6d1c) 97.84%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #6360 +/- ## ======================================= Coverage 97.84% 97.84% ======================================= Files 1110 1110 Lines 96690 96690 ======================================= Hits 94606 94606 Misses 2084 2084 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.