search

quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.28k stars 1.02k forks source link

Remove cached_property backport #6398

Closed Josha91 closed 10 months ago

Josha91 commented 10 months ago

As described in this issue: https://github.com/quantumlib/Cirq/issues/6395

The backport is no longer necessary and is therefore removed.

review-notebook-app[bot] commented 10 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

pavoljuhas commented 10 months ago

@Josha91 - it seems #6392 reintroduced some cached_property calls on the main branch.

Can you please replace those as well?

cc: @NoureldinYosri

codecov[bot] commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (4d35768) 97.80% compared to head (d7ebc71) 97.81%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6398 +/- ## ======================================= Coverage 97.80% 97.81% ======================================= Files 1111 1111 Lines 97088 97078 -10 ======================================= - Hits 94961 94957 -4 + Misses 2127 2121 -6 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.