quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.

Apache License 2.0

4.24k stars 1.01k forks source link

Make the pypirc generation script safer #6410

Closed pavoljuhas closed 8 months ago

pavoljuhas commented 8 months ago

avoid accidental modification of user's pypirc, instead have the script output new config without changing any file.
use absolute path in the shebang.
drop unnecessary triple quotes. In bash they just concatenate an empty string.
fail script early if required environment variables do not exist.

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (c8f7ed7) 97.81% compared to head (4d00579) 97.81%. Report is 2 commits behind head on main.

:exclamation: Current head 4d00579 differs from pull request most recent head 3cb69c1. Consider uploading reports for the commit 3cb69c1 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #6410 +/- ## ========================================== - Coverage 97.81% 97.81% -0.01% ========================================== Files 1111 1111 Lines 97088 97088 ========================================== - Hits 94965 94964 -1 - Misses 2123 2124 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

NoureldinYosri commented 8 months ago

@pavoljuhas wiil this work and not get a permission denied

pavoljuhas commented 8 months ago

@pavoljuhas wiil this work and not get a permission denied

strange, let me check this. converting to a draft for few test commits...

NoureldinYosri commented 8 months ago

@pavoljuhas I also have this draft https://github.com/quantumlib/Cirq/pull/6409. which one do you think we should go with?

pavoljuhas commented 8 months ago

@pavoljuhas I also have this draft #6409. which one do you think we should go with?

6409 looks good, let us go with that one.

pavoljuhas commented 8 months ago

@pavoljuhas wiil this work and not get a permission denied

strange, let me check this. converting to a draft for few test commits...

I see - the permission denied was happening for the main branch at ea6fabca78ed072e558f521dd94d9c716627b07e, because dev_tools/packaging/create_pypirc.sh did not have executable permission. This PR set the executable permission for the script so it passed the CI at 85261cd2204eac1f117765f18b9dd7731f147f35.

6409 is also a good solution so let us stick with that one.

pavoljuhas commented 8 months ago

Superseded by #6409