quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.24k stars 1.01k forks source link

Fix font family for svg #6423

Closed NoureldinYosri closed 7 months ago

NoureldinYosri commented 8 months ago

As per https://matplotlib.org/3.5.0/api/font_manager_api.html#matplotlib.font_manager.FontProperties Arial is not a valid font family with the only options being 'sans-serif' (default), 'serif', 'cursive', 'fantasy', or 'monospace'

The invalid input doesn't raise an error and instead fails silently with a warning message which is visible in the notebooks image

As per https://github.com/matplotlib/matplotlib/blob/f0c4c41d1a08bc3f53824cddc8fef7f88fc52a43/lib/matplotlib/mpl-data/stylelib/seaborn-v0_8.mplstyle#L18 Arial is part of the sans-serif family which is the default

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ee56c59) 97.81% compared to head (daed16f) 97.81%. Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6423 +/- ## ========================================== - Coverage 97.81% 97.81% -0.01% ========================================== Files 1111 1111 Lines 97121 97143 +22 ========================================== + Hits 95000 95018 +18 - Misses 2121 2125 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dabacon commented 7 months ago

Did you verify some basic diagrams look basically correct? Assuming that, LGTM

NoureldinYosri commented 7 months ago

@dabacon before before after after