search

quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.28k stars 1.02k forks source link

Update AQT Backend #6441

Closed jbrixon closed 7 months ago

jbrixon commented 9 months ago

Adjusted the AQT backend so that it works with the new AQT Arnica API. We also updated the gateset to reflect what we support. As we made an extension to the API, we were able to add a feature that lists the workspaces and resources that are available to a user. We also updated tests and documentation accordingly.

Fixes #6379

google-cla[bot] commented 9 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

review-notebook-app[bot] commented 9 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

dstrain115 commented 9 months ago

Also, you can fix the formatting by running check/format --apply

dstrain115 commented 7 months ago

It looks like there are some integration test failures. Once these are resolved, this should be good to merge! Thanks for addressing all the requested changes!

dstrain115 commented 7 months ago

Sent you an invite to be a collaborator, which should allow you to run CI on your own.

jbrixon commented 7 months ago

Sent you an invite to be a collaborator, which should allow you to run CI on your own.

Thanks. Have a weird mismatch between formatting locally and on CI. Was missing some test coverage too, but let's pretend that didn't happen..! Looks like everything's passing now finally...

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.79%. Comparing base (21986dd) to head (dab7e05).

:exclamation: Current head dab7e05 differs from pull request most recent head fd6e8c9. Consider uploading reports for the commit fd6e8c9 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6441 +/- ## ======================================== Coverage 97.78% 97.79% ======================================== Files 1124 1124 Lines 95493 95680 +187 ======================================== + Hits 93380 93570 +190 + Misses 2113 2110 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.