quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.28k stars 1.02k forks source link

support serialization of identity gate by converting it to phasedXZ #6458

Closed NoureldinYosri closed 8 months ago

NoureldinYosri commented 9 months ago

fixes https://github.com/quantumlib/Cirq/issues/4833

maffoo commented 9 months ago

We discussed adding a separate identity gate in the prior discuss on this (see https://github.com/quantumlib/Cirq/issues/4833#issuecomment-1050377165). Any reason not to do that? I think the goal of serialization has been to preserve circuits as much as possible, rather than converting to "equivalent" gates, but we haven't made a firm commitment to that goal.

NoureldinYosri commented 8 months ago

superseded by https://github.com/quantumlib/Cirq/pull/6479