quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.24k stars 1.01k forks source link

Add serialization support to more gates #6479

Closed NoureldinYosri closed 6 months ago

NoureldinYosri commented 7 months ago

This PR adds serializatoin support to

supersedes #6458

cc: @dstrain115 @maffoo

codecov[bot] commented 7 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.75%. Comparing base (4513892) to head (5b93695).

:exclamation: Current head 5b93695 differs from pull request most recent head 010012f. Consider uploading reports for the commit 010012f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6479 +/- ## ========================================== - Coverage 97.76% 97.75% -0.02% ========================================== Files 1105 1105 Lines 94963 94959 -4 ========================================== - Hits 92837 92823 -14 - Misses 2126 2136 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

verult commented 7 months ago

You might already thinking about this as a next step, but reminder to add to the device gateset as well. Happy to talk through the required changes if needed.

NoureldinYosri commented 6 months ago

@verult thanks for pointing that out. that will be a seprate PR if we need it.