search

quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.28k stars 1.02k forks source link

Remove python3.9 from CI tests #6495

Closed NoureldinYosri closed 8 months ago

NoureldinYosri commented 8 months ago

first step towards dropping py3.9 in cirq1.4 https://github.com/quantumlib/Cirq/issues/6463

codecov[bot] commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.76%. Comparing base (dc1065d) to head (758ba16).

:exclamation: Current head 758ba16 differs from pull request most recent head 526e70f. Consider uploading reports for the commit 526e70f to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6495 +/- ## ========================================== - Coverage 97.76% 97.76% -0.01% ========================================== Files 1105 1105 Lines 94999 95030 +31 ========================================== + Hits 92873 92902 +29 - Misses 2126 2128 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pavoljuhas commented 8 months ago

Is everyone OK with removing the CI status checks for 3.9 (Python Ubuntu (3.9) etc.) in the repo settings now? I can do so tomorrow unless there are objections.

pavoljuhas commented 8 months ago

@NoureldinYosri - there are few more places that I think can be bumped to 3.10 now, see below. Otherwise, LGTM.

.github/workflows/release-main.yml:18:          python-version: '3.9'
asv.conf.json:11:    "pythons": ["3.9"],
docs/dev/development.md:97:    Make sure you have python 3.9 or greater.
docs/start/install.md:15:Cirq currently supports python 3.9 and later.
docs/start/install.md:23:0. Make sure you have python 3.9.0 or greater.
docs/start/install.md:90:0. Make sure you have python 3.9.0 or greater.
docs/start/install.md:157:1. Make sure you have python 3.9.0 or greater.
release.md:85:System requirements: Linux, python3.9
NoureldinYosri commented 8 months ago

@pavoljuhas I updated the requested files, ptal

NoureldinYosri commented 8 months ago

@pavoljuhas I changed the branch protection rule to be for 3.10 rather than 3.9

pavoljuhas commented 8 months ago

@pavoljuhas I changed the branch protection rule to be for 3.10 rather than 3.9

Did the same right now. Can you please push an empty commit to restart the CI?