Closed verult closed 6 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 97.78%. Comparing base (
decf16d
) to head (d81a17d
). Report is 2 commits behind head on main.:exclamation: Current head d81a17d differs from pull request most recent head d037f0f. Consider uploading reports for the commit d037f0f to get more accurate results
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
This PR simplifies the experience of updating the supported gateset for
GridDevice
.The original reasons of separating of
serializable_forms
anddeserialized_forms
were twofolds:FSimGateFamily(gates_to_accept=[cirq.CZ])
does not acceptcirq.GateFamily(cirq.CZ)
, and similarly for other 2q gates.FSimGateFamily(gates_to_accept=[cirq.CZ])
andcirq.GateFamily(cirq.CZ)
were considered redundant for accepting the CZ gate).cirq.PhasedXZGate
instead ofcirq.GateFamily(cirq.PhasedXZGate)
).I prefer to merge these fields now because
cirq.GateFamily(cirq.CZ)
shouldn't be accepted by the gateset. Although rare, I don't think this is what we want.cc @wcourtney