search

quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.24k stars 1.01k forks source link

Removed deprecated processor_ids #6563

Closed JaShom closed 5 months ago

JaShom commented 5 months ago

Removed deprecated processor_ids in Engine, EngineProgram and EngineClient from issue #6271

JaShom commented 5 months ago

Sorry for the @'s but could someone review this, please? @verult @cduck @wcourtney @vtomole

JaShom commented 5 months ago

@wcourtney are the changes alright?

codecov[bot] commented 5 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.78%. Comparing base (e1b03ef) to head (4346bf3). Report is 2 commits behind head on main.

:exclamation: Current head 4346bf3 differs from pull request most recent head 32a7bb2. Consider uploading reports for the commit 32a7bb2 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6563 +/- ## ========================================== - Coverage 97.79% 97.78% -0.01% ========================================== Files 1124 1124 Lines 95684 95466 -218 ========================================== - Hits 93574 93352 -222 - Misses 2110 2114 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

JaShom commented 5 months ago

@wcourtney I've resolved all the failures :)

JaShom commented 5 months ago

@wcourtney Is it good now?

JaShom commented 5 months ago

Thanks guys @wcourtney @pavoljuhas