search

quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.24k stars 1.01k forks source link

Make implicit Optional type hints in Quantum Engine PEP 484 compliant #6640

Closed senecameeks closed 3 months ago

senecameeks commented 3 months ago

Fixes https://github.com/quantumlib/Cirq/issues/6638

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.81%. Comparing base (543d9cd) to head (d14a60d).

:exclamation: Current head d14a60d differs from pull request most recent head db0b9fa

Please upload reports for the commit db0b9fa to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6640 +/- ## ======================================= Coverage 97.81% 97.81% ======================================= Files 1067 1067 Lines 91550 91550 ======================================= Hits 89549 89549 Misses 2001 2001 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

maffoo commented 3 months ago

This is generated code, right? Would it help to regenerate it at some point with a newer gapic version?