search

quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.24k stars 1.01k forks source link

fix error on msgate unitary matrix #6645

Closed rjain37 closed 3 months ago

rjain37 commented 3 months ago

The old MSGate had $\frac{\theta}{2}$ as the argument to the trigonometric functions in the matrix. however, after some testing i realized that the unitary matrix is actually defined with $\pi\theta$ as the argument to those trigonometric functions. As such, I have added those to the documentation/docstring.

google-cla[bot] commented 3 months ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.81%. Comparing base (4b8e8e4) to head (56fb916).

:exclamation: Current head 56fb916 differs from pull request most recent head 60bcfb6

Please upload reports for the commit 60bcfb6 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6645 +/- ## ========================================== - Coverage 97.81% 97.81% -0.01% ========================================== Files 1066 1066 Lines 91779 91703 -76 ========================================== - Hits 89773 89697 -76 Misses 2006 2006 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.