quantumlib / Cirq

A Python framework for creating, editing, and invoking Noisy Intermediate Scale Quantum (NISQ) circuits.
Apache License 2.0
4.28k stars 1.02k forks source link

Enforces specifying run_name and device_config_name on Engine interfaces #6649

Closed senecameeks closed 4 months ago

senecameeks commented 4 months ago

Removes default values and enforces specifying run_name and device_config_name

Special note that this does not disrupt the workflow

sampler = processor.get_sampler(  
        run_name="run_name", device_config_name="config_alias"
    )

sampler.run_batch([circuit] * 20, repetitions=500) 
## or
sampler.run_sweep(circuit, params=[...], repetitions=500) 
senecameeks commented 4 months ago

@NoureldinYosri added Breaking Change tag for posterity

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 97.81%. Comparing base (0aae3c1) to head (0497c85). Report is 1 commits behind head on main.

:exclamation: Current head 0497c85 differs from pull request most recent head ee4ae61

Please upload reports for the commit ee4ae61 to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #6649 +/- ## ======================================= Coverage 97.81% 97.81% ======================================= Files 1066 1066 Lines 91779 91779 ======================================= Hits 89773 89773 Misses 2006 2006 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

pavoljuhas commented 4 months ago

@senecameeks - please wait for #6650 to make it in and then merge it here.