Consider a unique definition for Wavefunction

quantumlib / OpenFermion-FQE

The Fermionic Quantum Emulator (FQE) is a fermionic simulation research tool specializing in quantum circuits emulating fermion dynamics.

Apache License 2.0

61 stars 25 forks source link

Consider a unique definition for Wavefunction #63

Open rmlarose opened 3 years ago

rmlarose commented 3 years ago

Wavefunction is currently multiply defined, once as the class and once as a getter function for the class. This caused a few issues with mypy, and while they are easily resolved by importing the correct Wavefunction, there is a chance for confusion. Perhaps refactor the function to get_wavefunction or a similar name?

wjhuggins commented 2 years ago

This causes additional problems with Pylance in VSCode. It really would be a nice change even if it's annoying to break people's code.

wjhuggins commented 2 years ago

Would a PR that does this be approved?