Closed sunqm closed 6 years ago
We usually test in python 2.7, 3.4, 3.5 and 3.6. @Strilanc can you help us configure travis based on this PR?
@sunqm let me know when you are going to work on this repo imminently. We can then prioritize setting up travis (which is going to be somewhat of a battle I fear).
So there's good news and bad news.
:thumbsup: The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.
:confused: The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.
Note to project maintainer: This is a terminal state, meaning the cla/google
commit status will not change from this state. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.
@babbush Don't worry. No rush on me.
I'm figuring that if I made changes on my fork, it may mess up the PR. Will it be more convenient if I close this PR now and wait for you guys deciding how to set up travis?
It is fine to leave it open actually. Feel free to mess it up ;-)
But you are also welcome to close it. Makes no difference to me.
Travis CI config file was added.