search

quantumlib / OpenFermion-PySCF

OpenFermion plugin to interface with the electronic structure package PySCF.
Apache License 2.0
105 stars 44 forks source link

Remove pytest from install_requires #57

Closed r-imai-quantum closed 3 years ago

r-imai-quantum commented 3 years ago

When you run pip install openfermionpyscf, pytest is installed together since it is in setup_requires field of setup.py. Only developers need pytest, so it is good to remove pytest from setup_requires field.

r-imai-quantum commented 3 years ago

CI failed becauce of wrong settings in ci.yml, which will be fixed #58.

ncrubin commented 3 years ago

Hi @r-imai-quantum Thank you for this fix. I think the better fix would be to actually make a dev_tools/pip-list instead of just removing pytest. Could. you do that with this PR?

r-imai-quantum commented 3 years ago

Thank you for your comments. @ncrubin Please let me confirm one thing. Does dev_tools/pip-list you mentioned mean a list of dependencies to execute tests?

ncrubin commented 3 years ago

That is correct. For this it will be pyscf, pytest, openfermion.

r-imai-quantum commented 3 years ago

Updated. Could you check again? @ncrubin