quantumlib / OpenFermion

The electronic structure package for quantum computers.
Apache License 2.0
1.51k stars 373 forks source link

Symm cons keywords #652

Closed philipp-q closed 4 years ago

philipp-q commented 4 years ago

This PR addresses an issue, that appears when using the symmetry_conserving_bravyi_kitaev transformation on operators acting only on a subset of qubits of the whole Hamiltonian (e.g. when one wants to determine the entries of the 2-RDM). This may not be very useful on certain systems (e.g. 2 fermions, 4 orbitals), as the transformation does not yield any benefit, but allows broader application.

Fixed by simple addition of 2 keywords in src/openfermion/transforms/opconversions/remove_symmetry_qubits.py + added a test with a dummy operator.

(A similar issue appears with the BKSF transformation, but would require deeper changes)

googlebot commented 4 years ago

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

:memo: Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

philipp-q commented 4 years ago

@googlebot I signed it!

googlebot notifications@github.com schrieb am Do., 20. Aug. 2020, 11:23:

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.

What to do if you already signed the CLA Individual signers

Corporate signers

ℹ️ Googlers: Go here https://goto.google.com/prinfo/https%3A%2F%2Fgithub.com%2Fquantumlib%2FOpenFermion%2Fpull%2F652 for more info.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/quantumlib/OpenFermion/pull/652#issuecomment-677485293, or unsubscribe https://github.com/notifications/unsubscribe-auth/APESHVWQV5NI5W7F6IR4Z4LSBTTSJANCNFSM4QF23HDQ .

googlebot commented 4 years ago

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. In order to pass this check, please resolve this problem and then comment @googlebot I fixed it.. If the bot doesn't comment, it means it doesn't think anything has changed.

ℹ️ Googlers: Go here for more info.

philipp-q commented 4 years ago

@googlebot I fixed it.