search

quantumlib / OpenFermion

The electronic structure package for quantum computers.
Apache License 2.0
1.51k stars 372 forks source link

Some inconsistencies in molecular single factorization costings #838

Closed fdmalone closed 3 months ago

fdmalone commented 11 months ago

the variable nprime has the second term divided by 4 instead of 2 https://github.com/quantumlib/OpenFermion/blob/a034397a13b1ea224e11746d4ee368cccf2bc962/src/openfermion/resource_estimates/sf/compute_cost_sf.py#L72 as per eq. B13.

The inverse QROM should be on two registers (QI2) not one (QI).

fdmalone commented 9 months ago

Looking again more closely, B19 is actually a typo, the amount of data is N/2*(N/2 + 1) / 2 = N^2/8 + N/4