search

quantumlib / OpenFermion

The electronic structure package for quantum computers.
Apache License 2.0
1.51k stars 372 forks source link

Fix scipy sqrtm precision issue #864

Closed fdmalone closed 7 months ago

fdmalone commented 7 months ago

Addresses #815 by replacing la.sqrtm with the square root computed via eigendecomposition. Just bumping the input array's precision to 256 didn't solve the problem.

fdmalone commented 7 months ago

See #865 which tracks the capping of cirq for the CI.

fdmalone commented 7 months ago

Will need to cut a new release to fix #851.

fdmalone commented 7 months ago

I need to fix a comment typo don't merge.

natestemen commented 7 months ago

Hey happy to see this fixed! Any idea when it will be released? It will help us unblock some dependency upgrades over on unitaryfund/mitiq.

fdmalone commented 7 months ago

@natestemen I'll aim to release a patch by the end of the week.

Misty-W commented 6 months ago

hi @fdmalone, hope you don't mind my asking when the patch mentioned in the previous comment is likely to be released? As my teammate Nate mentioned last week, folks on the Mitiq project are excited to see this upgrade in the pipeline!

fdmalone commented 6 months ago

@Misty-W , I just released a patched verison

Misty-W commented 6 months ago

@Misty-W , I just released a patched verison

Fantastic, many thanks @fdmalone!!