Replace `_t_complexity_` with `build_call_graph` in comparison gates

quantumlib / Qualtran

Qᴜᴀʟᴛʀᴀɴ is a Python library for expressing and analyzing Fault Tolerant Quantum algorithms.

https://qualtran.readthedocs.io/en/latest/

Apache License 2.0

173 stars 40 forks source link

Replace `_t_complexity_` with `build_call_graph` in comparison gates #1012

Closed tanujkhattar closed 4 months ago

tanujkhattar commented 4 months ago

Fixes https://github.com/quantumlib/Qualtran/issues/1010

Helps support symbolics and better resource counting for comparison gates.

Edit: Also updated LessThanEqual gate.

NoureldinYosri commented 4 months ago

@tanujkhattar this PR becomes obsolete once I merge my upcoming PR that reimplements all comparison gates + adds missing comparison gates. I will send the PR today.

tanujkhattar commented 4 months ago

I think this is a fairly straightforward change, so lets merge this and then I will lookout for your PR with the revamp? In case we are not able to merge your PR in time for the release; this would be a good temporary solution to unblock other upgrades.

mpharrigan commented 4 months ago

this broke the leq_symb bloq example, which tragically isn't included in a unit test

tanujkhattar commented 4 months ago

Yeah, I'll send a fix soon. Realized it when implementing symbolic state prep