quantumlib / Qualtran

Qᴜᴀʟᴛʀᴀɴ is a Python library for expressing and analyzing Fault Tolerant Quantum algorithms.
https://qualtran.readthedocs.io/en/latest/
Apache License 2.0
132 stars 35 forks source link

`AddConstantMod` --> `ModAddK` doesn't support simulation anymore #1046

Open tanujkhattar opened 1 month ago

tanujkhattar commented 1 month ago

https://github.com/quantumlib/Qualtran/pull/907/files#diff-d7e11e9a89cbedc95f75813093320217796e881bbb0d0427216aea88e86c7755 reorganized the modular arithmetic bloqs. As part of the organization, AddConstantMod was renamed to ModAddK and cirq.ArithmeticGate was removed as a base class.

This led to the bloqs not supporting simulation / tensor contraction anymore; which is bad because this bloq is used from PrepareHubbard and all other bloqs in the decomposition of hubbard model support simulation.

We should fix this.