search

quantumlib / Qualtran

Qᴜᴀʟᴛʀᴀɴ is a Python library for expressing and analyzing Fault Tolerant Quantum algorithms.
https://qualtran.readthedocs.io/en/latest/
Apache License 2.0
132 stars 35 forks source link

Added documentation, notebook, and build_call_graph for QFTTextBook #1060

Open matthagan15 opened 3 weeks ago

matthagan15 commented 3 weeks ago

Additional documentation and notebooks for QFT per https://github.com/quantumlib/Qualtran/issues/978 , also added a build_call_graph for QFTTextBook.

mpharrigan commented 3 weeks ago

You can use check/format-incremental --apply check/pylint and check/mypy and check/pytest to see and fix the ci checks locally

matthagan15 commented 3 weeks ago

I had run the formatter locally, not sure why it passed on my machine but not the CI? Also I tried running each of the other checks locally but each one failed for a different reason.

matthagan15 commented 1 week ago

Just updated this PR with CI fixes, let me know if anything else needs to be addressed!

mpharrigan commented 1 week ago

@tanujkhattar are your review comments addressed?

tanujkhattar commented 1 week ago

Looking at it again now