search

quantumlib / Qualtran

Qᴜᴀʟᴛʀᴀɴ is a Python library for expressing and analyzing Fault Tolerant Quantum algorithms.
https://qualtran.readthedocs.io/en/latest/
Apache License 2.0
132 stars 35 forks source link

mean_estimation.complex_phase_oracle_test.test_phase_oracle is very slow because of Fxp #1072

Open mpharrigan opened 3 weeks ago

mpharrigan commented 3 weeks ago

This is the change: https://github.com/quantumlib/Qualtran/pull/1041/files#r1638968757

Somehow, this has turned the parameterized unit test from a 1 second to a 21 second ordeal on my machine.

Is it worth resuscitating our own fixed-point-bits function? or is there a better incantation to the Fxp library to get it to go faster?

Perhaps related: https://github.com/quantumlib/Qualtran/issues/643#issuecomment-2065491533

fdmalone commented 3 weeks ago

I never dug into what was the cause of the slowness, whether it was Fxp or whether it was something else.